search

bnoordhuis / node-iconv

node.js iconv bindings - text recoding for fun and profit!
Other
797 stars 123 forks source link

src: use `Nan::SetMethod()` for exports #199

Closed richardlau closed 5 years ago

richardlau commented 5 years ago

Let NAN take care of the ToLocalChecked() calls and removes direct reference to v8::FunctionTemplate.

richardlau commented 5 years ago

Found some of the other using declarations were unused so I've removed them while I was here.

bnoordhuis commented 5 years ago

Thanks Richard, landed in ac4e95b...94bca0c.