search

bnoordhuis / v8-cmake

The V8 JavaScript engine, but built with CMake instead of GN - WIP
BSD 3-Clause "New" or "Revised" License
189 stars 54 forks source link

v8-i18n-support issue #39

Closed hejian1639 closed 4 years ago

hejian1639 commented 4 years ago 
You have called ADD_LIBRARY for library v8-i18n-support without any source files. This typically indicates a problem with your CMakeLists.txt file
CMake Error at CMakeLists.txt:154 (target_link_libraries):
  Object library target "v8-i18n-support" may not link to anything.

I got this issue on ubuntu 18 , when cmake runs, it works on my MacBook

bnoordhuis commented 4 years ago

Are you passing -DV8_ENABLE_I18N=ON to cmake? i18n builds aren't working yet, pending resolution of #4.

hejian1639 commented 4 years ago 
cmake -DCMAKE_BUILD_TYPE=Debug

above is my arguments and I tried -DV8_ENABLE_I18N=ON/OFF both, still same result ...

bnoordhuis commented 4 years ago

I'm afraid I can't reproduce. My best guess it's a cmake incompatibility. I'm testing with cmake 3.16.3.

hejian1639 commented 4 years ago

yes, I guess so , I use latest cmake , it works now. thank u.

bnoordhuis commented 4 years ago

Glad to hear it's working now. I'll close the issue.