search

bnoordhuis / v8-cmake

The V8 JavaScript engine, but built with CMake instead of GN - WIP
BSD 3-Clause "New" or "Revised" License
189 stars 54 forks source link

feat: bump to v8 9.6 #50

Closed gengjiawen closed 2 years ago

gengjiawen commented 2 years ago 
/Users/jiawengeng/code/v8-cmake/v8/src/compiler/code-assembler.h:163:1: error: unknown type name 'WasmValueObject'; did you mean 'WasmTableObject'?
HEAP_OBJECT_ORDINARY_TYPE_LIST(OBJECT_TYPE_CASE)

any hint for this error ? I found the object exist on debug-interface.h, and included.

cc @bnoordhuis

bnoordhuis commented 2 years ago

You probably need to add v8/src/debug/debug-wasm-objects{.cc,.h,-inl.h}.

gengjiawen commented 2 years ago

You probably need to add v8/src/debug/debug-wasm-objects{.cc,.h,-inl.h}.

Found a silly mistake I have taken, now stuck on

/Users/jiawengeng/code/v8-cmake/v8/src/builtins/setup-builtins-internal.cc:336:3: error: no member named 'kLdaNamedPropertyNoFeedback' in 'v8::internal::interpreter::Bytecode'
  BUILTIN_LIST(BUILD_CPP, BUILD_TFJ, BUILD_TFC, BUILD_TFS, BUILD_TFH, BUILD_BCH,

I have found kLdaNamedProperty, not sure where NoFeedback comes from.

the error is misleading, a wrong inlcude

gengjiawen commented 2 years ago

classic fails only on MSVC 😓

gengjiawen commented 2 years ago

Thanks to the old issue: https://github.com/bnoordhuis/v8-cmake/issues/10.

gengjiawen commented 2 years ago

Upstream patch: https://chromium-review.googlesource.com/c/v8/v8/+/3366367.