search

bnoordhuis / v8-cmake

The V8 JavaScript engine, but built with CMake instead of GN - WIP
BSD 3-Clause "New" or "Revised" License
189 stars 54 forks source link

:bug: Fixed v8_torque_generated failing to build on Windows #82

Closed AnotherFoxGuy closed 8 months ago

AnotherFoxGuy commented 8 months ago

The torque-outputs and torque_outputs variables can have too many characters on Windows to be executed on the command line, so we have to write it to a temporary file and execute that

Fixes #67 Fixes #42

bnoordhuis commented 8 months ago

Nice. This should also help move #66 along, I think?

AnotherFoxGuy commented 8 months ago

I think so, but maybe at some point the torque_files variable might also become too long

bnoordhuis commented 8 months ago

Thanks for the pull request, Edgar.