search

bnordli / rftg

Race for the Galaxy AI
173 stars 32 forks source link

Clean up code. #47

Closed o01eg closed 7 years ago

o01eg commented 7 years ago

Should source tree contains configure, Makefile.in and other autogenerated files with created by autoreconf?

bnordli commented 7 years ago

Not really. I build mainly on Windows, so haven't done much to the Unix build setup.

Feel free to remove the generated files in your PR!

There is one Makefile.in in the network folder as well!

Marsux commented 7 years ago

I think yes. On linux, usually you are able to build with only configure and make.

Le 11/02/2017 12:24, O01eg a écrit :

Should source tree contains |configure|, |Makefile.in| and other autogenerated files with created by |autoreconf|?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bnordli/rftg/issues/47, or mute the thread https://github.com/notifications/unsubscribe-auth/AVd0ZIe41xWwb2HrGpTikbIX8P6vgV_bks5rbZpZgaJpZM4L-JrE.

bnordli commented 7 years ago

Oh, I see, there are two pre-build steps, autoreconf and configure. In this case, perhaps it is best to keep the output of the first step, as Marsux said. (I am not very familiar with this process.)

gchambers419 commented 7 years ago

Speaking as someone who is familiar with Linux build processes, the configure.in file is in the repository so that people doing development can update it as needed. The generated configure file is committed so that a non-developer can do a checkout and build without the full autotools suite being installed.

In the days before publicly visible repositories, the generated files might not have been checked in, but would still be part of the source code tarball.

bnordli commented 7 years ago

Thanks for the input! Let's keep them, then!

I'll take a look at your PR when I have time.