search

bnorm / kotlin-power-assert

Kotlin compiler plugin to enable diagrammed function calls in the Kotlin programming language
Apache License 2.0
581 stars 15 forks source link

configure to run tests in parallel and eliminate global state #73

Closed christophsturm closed 1 year ago

christophsturm commented 2 years ago

this speeds up a ./gradlew cleanTest test run from 14 seconds to 5 seconds on my m1 macbook pro. If you like I can also create a PR that converts the test suite to https://github.com/failgood/failgood, which will probably make it even faster, simpler and nicer to read </commercial>

christophsturm commented 2 years ago

@TWiStErRob thanks for your feedback, I have found out that the whole "making file name unique" effort was not needed and that the only problem was System.out. so now this PR turned out really simple.

TWiStErRob commented 2 years ago

Niiice! (You can resolve most comments then)

christophsturm commented 2 years ago

about the formatting, maybe we could also add the kotlinter gradle plugin to run formatting locally and not only check it on CI

christophsturm commented 1 year ago

However, I'm not sure I like the conversion to exceptions for these tests. Use of println was sort of a hack to emulate a proper logging framework. I wonder if we can add a top-level StringBuilder to the dbg code which can be accessed after main is executed or if we can integrate with JUL somehow.

yes, I just fixed it in the simplest way that I could think of, the idea of the PR was mainly to show what problems we have when running test in parallel.

also I'm excited to see activity again in this repo!