search

bnpr / Malt

Render framework for NPR.
https://malt3d.com
Other
952 stars 75 forks source link

Copy node groups to a new node tree leads to a transparent diffuse #416

Closed HSDSZ closed 1 year ago

HSDSZ commented 1 year ago

Malt version

node-groups-latest

Blender version

Blender 3.30

OS

win 11

Hardware info

intel i7 | gtx 1660

Issue description and reproduction steps

  1. Here is a very simple node group added to main pass color. the node group is a vec3 add of npr diffuse and npr specular. Everything is fine here image

  2. create a new material and a new node tree, assign the new material to the object. image

  3. copy the node group to the new material node tree, then connect it to the new mainpass color

image

two issues

first, the object becomes transparent second, the parameters of the node group disappear

Reload pipelline or restart blender won't help

Attachments

[Uploading bug.zip…]()

pragma37 commented 1 year ago

The attachment link doesn't work!

HSDSZ commented 1 year ago

The attachment link doesn't work!

oh sorry, here is the file bug.zip

HSDSZ commented 1 year ago

https://user-images.githubusercontent.com/36077492/194760223-87533dcf-4a28-4013-adf9-6d5b73c4a4b4.mp4

pragma37 commented 1 year ago

The issue was that all-caps names in Malt are considered internal and don't get exposed on the UI. So since your node name is "NPR", all parameters were being considered as internal engine stuff.

The internal node name is assigned on node creation and never changes after that, that's why the problem would only show up after a copy.