bnpr / Malt

Render framework for NPR.
https://malt3d.com
Other
981 stars 75 forks source link

RGB Curves in Geo Nodes breaks Vertex Colors #441

Closed dibli-goost closed 1 year ago

dibli-goost commented 1 year ago

Malt version

Node Groups

Blender version

Blender 3.3

OS

Windows 10

Hardware info

AMD Ryzen Threadripper 1920x 12-Core Processor, 3950 Mhz, 24 Logical Processors | 32GB RAM | Radeon RX 570 Series

Issue description and reproduction steps

When transferring Vertex Color Attributes out of Geo Nodes and into Malt, if a RGB Curves is linked in the node tree, it will break any Color Attribute it is connected to.

image

Sometimes it also seems to create this faceted look, but I'm not really sure why it's not happening in the attached blend.

image

image

I did test in EEVEE too, and it does seem to work there just fine.

Attachments

Geometry Nodes RGB Curves Bug.zip

pragma37 commented 1 year ago

It seems like the RGB Curves node sets the alpha to 0. imagen imagen

I guess EEVEE doesn't read the alpha value from Vertex Colors, so Geometry Nodes ignore the alpha value. Vertex colors alpha is kind of weird in Blender because they're there but AFAIK they're not really used anywhere.

In any case, this is not really an error on the Malt side. And I don't think we should ignore the vertex color alpha to "fix" it.