bnpr / Malt

Render framework for NPR.
https://malt3d.com
Other
981 stars 75 forks source link

Depth Width Lines generated incorrectly in Screen Shader. #504

Closed dibli-goost closed 1 year ago

dibli-goost commented 1 year ago

Malt version

Node Groups

Blender version

Blender 3.5

OS

Windows 10

Hardware info

AMD Ryzen Threadripper 1920x 12-Core Processor, 3950 Mhz, 24 Logical Processors | 32GB RAM | Radeon RX 570 Series

Issue description and reproduction steps

When using the Line Width or Line Detection nodes in a screen pass. Depth Width lines are not generated correctly.

For comparison:

When Depth Width is used in a mesh shader. image

When Depth Width is used in a screen shader. image

Honestly kind of embarrassed that I didn't notice this sooner. Since I've been generating lines in the screen shader directly for ages now. I'd guess the issue is being caused by normal depth not being properly passed into Line Detection when in the screen shader.

Attachments

Line Width Screen Pass bug.zip

pragma37 commented 1 year ago

Fixed! Thanks for the report.