bnpr / Malt

Render framework for NPR.
https://malt3d.com
Other
952 stars 75 forks source link

Currently open Node Group is exited when undoing a change inside the Group #547

Open StarshipAmelia opened 5 months ago

StarshipAmelia commented 5 months ago

Malt version

node-groups-latest 540a606

Blender version

Blender 4.0.2

OS

Linux 6.7.0-0-MANJARO

Hardware info

AMD Ryzen 7 2700X | 32GB RAM | AMD Radeon RX 580 8GB

Issue description and reproduction steps

While viewing a node group in a Malt material (by selecting the node and hitting tab) and changing something inside the group (ex: changing the values in a node), then undoing that change, the view exits the group & returns to the non-group view.

The undo seems to work as expected otherwise, but it's very disruptive to the workflow when one is editing something inside a node group. Activating undo either via CTRL+z or using the F3 menu to search for 'undo' has the same result

I don't think this has the same cause as Issue 442, as I made sure to use a clean blender profile. (I moved ~/.config/blender/4.0 to another location, and had Blender use the defaults rather than the previous version's settings on the first startup after that). I also tried disabling all addons except Malt, with no observable change in behavior

I think that this issue has been present for some time (months or more), but I've been rather under the weather recently, and so haven't had a chance to properly write this up

Attachments

malt 2024-01-30(23-50).log groups not working after ctrl+z.zip

Included in the zip is a short video demonstrating the issue. I enter the group via the tab key, change some values, and then hit CTRL+Z, which exits the group

Also included in the zip is the blend file in which this happened, but it happens in all that I've tried, including ones that I didn't make (blend files people have shared in the discussions area in this repository)

The only changes to the blend file's settings from the defaults were closing some panes in the default Shader view, changing the color space to Standard, and switching to Malt