bnprks / BPCells

Scaling Single Cell Analysis to Millions of Cells
https://bnprks.github.io/BPCells
Other
166 stars 17 forks source link

Fix broken Mac build and add CI checks #141

Closed bnprks closed 3 weeks ago

bnprks commented 1 month ago

This is designed to fix issue #140 and prevent similar issues in the future by having checks run on new PRs.

It turns out there was more than one thing wrong with the builds, so the list of fixes is:

There remain two unfixed issues to follow up on. For now, the relevant tests have been marked to skip:

A future follow-up goal to improve CI would be fixing all the skipped tests and adding test coverage tracking via covr

immanuelazn commented 3 weeks ago

Changes look good! I'll prioritize doing the windows multithreaded insertion bedfile writing next. Thanks Ben!