bnprks / BPCells

Scaling Single Cell Analysis to Millions of Cells
https://bnprks.github.io/BPCells
Other
166 stars 17 forks source link

[r] Fix leiden tests in CI #152

Closed bnprks closed 3 weeks ago

bnprks commented 3 weeks ago

This fixes leiden tests that succeeded with devtools::test() but fail under testthat::test_dir() used in CI.

The soft deprecation warning only showed up in CI, so I've adjusted the tests to not fail when encountering the soft deprecation warning.

The reason not to change the underlying code is that igraph only introduced the new parameter name 4 months ago (link), and I don't want to force people to upgrade igraph that quickly in order to use BPCells. We can address the underlying deprecation later once there has been a bit more time for people to upgrade their igraph.

immanuelazn commented 3 weeks ago

Looks good Ben!