search

bnvk / Conjuror

An experiment in the CSV format, open data, magic, and wizardly things!
Other
11 stars 2 forks source link

Set Currency, Add extra field, Add filters for this week and this month. #24

Closed simonv3 closed 9 years ago

simonv3 commented 9 years ago

I realized that I hadn't done a PR in a while.

what's changed

bnvk commented 9 years ago

@simonv3 dang son, I actually just started messing with a currency conversation feature on my local branch as it just came up for one of my clients! Thanks for this headstart :+1:

bnvk commented 9 years ago

@simonv3 actually, bad news buddy. I had to revert the master, as I only ran the unit tests, not the actual feature. Upon trying the actual feature, the --date flag only filtered the most recent week instead of the actual argument!

simonv3 commented 9 years ago

Bummer! Next week I'll spend some time writing more tests. I don't have time for this right now, but maybe it makes sense to make a list of test cases to pass for the scripts. On Apr 3, 2015 8:39 PM, "Brennan Novak" notifications@github.com wrote:

@simonv3 https://github.com/simonv3 actually, bad news buddy. I had to revert the master, as I only ran the unit tests, not the actual feature. Upon trying the actual feature, the --date flag only filtered the most recent week instead of the actual argument!

— Reply to this email directly or view it on GitHub https://github.com/bnvk/Beardo/pull/24#issuecomment-89290379.