bnvk / Conjuror

An experiment in the CSV format, open data, magic, and wizardly things!

Other

11 stars 2 forks source link

Refactor of File Reading #28

Closed simonv3 closed 9 years ago

simonv3 commented 9 years ago

What's Changed

Moved the argument options into their own file, to shorten Beardo itself.
Moved file operations into one function that uses a promise and returns a buffer or an Error. and into a prepareRecipe file.
What's next
This was all to have file reading be easier, so that #27 can be implemented.

bnvk commented 9 years ago

@simonv3 looks like good changes bud. It test the functionality and everything works fine. However, one of the date specific unit tests is failing, but I'll merge it in anyway. I'll ping you on IRC to catch up soon :)

simonv3 commented 9 years ago

@bnvk That'll be the failing month one - the test is right, the code just isn't yet, it hasn't been implemented, and I was letting the test fail so that I remember. This is concerning the implementation of "this April" whereas right now Beardo gets "all Aprils ever".

bnvk / Conjuror

Refactor of File Reading #28

What's Changed

What's next