search

bnw / firefly-iii-fints-importer

Import financial transactions from you FinTS enabled bank into Firefly III.
GNU Affero General Public License v3.0
155 stars 23 forks source link

Allows to fully automate even if tan medium required #110

Closed baflo closed 1 year ago

baflo commented 1 year ago

Hi,

I am not familiar with PHP and don't know if this is a good solution. However with this change I was able to fully automate the download from german DKB accounts which required to set up the TAN medium only once and then continues to work without 2FA.

I could imagine that there's error handling missing, but I am too unfamiliar with it to efficiently solve that. I think as a user I'd expect to get an error status, if automation does not work anymore and also that this is not implemented, yet.

It's even possible that the part in Choose2FADevice.php is counter-productive and should be removed.

bnw commented 1 year ago

Hi, thanks a lot for your contribution! Instead of your solution, I opted to include 2FA device into the config file. This should also work for people that can choose from more than one device. See 0192cb8995c376e584dbeba3bc419fe662b1cb50

And yes, you are correct that quite a bit of error handling is not implemented 🙃