bnw / firefly-iii-fints-importer

Import financial transactions from you FinTS enabled bank into Firefly III.
GNU Affero General Public License v3.0
151 stars 23 forks source link

[Documentation] Where to add additional documentation for a specific Bank #143

Closed 89Q12 closed 1 day ago

89Q12 commented 2 weeks ago

I'm using this for IngDiBa, as I recently changed my password using their website to one with more than 10 characters. This results in this error: ` Fatal error: Uncaught Fhp\Protocol\ServerException: FinTS errors: 9800 (global): Der Dialog wurde abgebrochen. 9942 (global): Anmeldung nur mit 10-stelliger Kontonummer und 5 bis 10-stelliger PIN möglich. in /vendor/nemiah/php-fints/lib/Fhp/Protocol/ServerException.php:170 Stack trace:

0 /vendor/nemiah/php-fints/lib/Fhp/FinTs.php(963): Fhp\Protocol\ServerException::detectAndThrowErrors(Object(Fhp\Protocol\Message), Object(Fhp\Protocol\Message))

1 /vendor/nemiah/php-fints/lib/Fhp/FinTs.php(307): Fhp\FinTs->sendMessage(Object(Fhp\Protocol\Message))

2 /vendor/nemiah/php-fints/lib/Fhp/FinTs.php(832): Fhp\FinTs->execute(Object(Fhp\Protocol\DialogInitialization))

3 /vendor/nemiah/php-fints/lib/Fhp/FinTs.php(705): Fhp\FinTs->executeWeakDialogInitialization(NULL)

4 /vendor/nemiah/php-fints/lib/Fhp/FinTs.php(259): Fhp\FinTs->ensureSynchronized()

5 /app/Login.php(23): Fhp\FinTs->login()

6 /app/TanHandler.php(41): App\StepFunction{closure}()

7 /app/TanHandler.php(31): App\TanHandler->create_or_continue_action()

8 /app/Login.php(21): App\TanHandler->__construct(Object(Closure), 'login-action', Object(Symfony\Component\HttpFoundation\Session\Session), Object(Twig\Environment), Object(Fhp\FinTs), Object(App\Step), Object(Symfony\Component\HttpFoundation\Request))

9 /app/index.php(59): App\StepFunction\Login()

10 {main}

thrown in /vendor/nemiah/php-fints/lib/Fhp/Protocol/ServerException.php on line 170
`

Where should I add documentation that a password between 5 and 10 characters is needed for IngDiBa to function?

(I think that adding this under tips is a good place.)

bnw commented 1 week ago

Oh man, that's an annoying error :D

Having some bank-specific tips is probably a good idea. How about a section "Bank specifics" or similar at the end of the Readme? I would rather put them at the end of the Readme (as opposed to Tips, which is in the middle), because for most users, they are probably irrelevant.

89Q12 commented 1 week ago

Yeah good point! Will do a PR once I come around to it, thanks for the timely input :)

Edit: Ignore the one mentioned PR, github did a stupid on me haha