search

bnw / firefly-iii-fints-importer

Import financial transactions from you FinTS enabled bank into Firefly III.
GNU Affero General Public License v3.0
155 stars 23 forks source link

Fix/enable decoupled tan submission #145

Closed JuliusFreudenberger closed 2 months ago

JuliusFreudenberger commented 2 months ago

This is my second attempt to fix #131 after #142 was merged but had a problem related to outdated dependencies. It includes the same commits and an additional commit updating the nemiah/phpfints dependency. I used the following command composer update nemiah/php-fints phpspec/prophecy phpunit/phpunit. prophecy and phpunit had to be updated as well (I guess it is related to the requirement of php>=8.0). Using a locally built docker container I could also import statements successfully, so I think the current dependency situation should not lead to any more problems.

This also brings up the question if anything else has to be done due to the new requirement php>=8.0?

To keep everything together, here also the important part of the description of the old PR: This adds the basic functionality for decoupled TAN checks, presented by phpFinTs. I could confirm this working with my Sparkasse bank account.

However, this implementation has a caveat: Confirming the import in the pushTAN app is necessary every time an import is started. Also this adds an entry to the list of saved devices in device management (Geräteverwaltung). This is also an issue in phpFinTs: https://github.com/nemiah/phpFinTS/issues/453, where it is described as an issue with the "kundensystemId"

bnw commented 2 months ago

Again, thanks a lot! 😊 The current dockerfile already uses php 8.1, so this should not be a problem. It’s normal that updating one package also requires updating some others. But these ones are probably not problematic 👍

JuliusFreudenberger commented 2 months ago

I did another test in the docker environment using the image provided by you and I did not encounter any errors. Now I can import my statements into firefly again.

UebertreibeR commented 2 months ago

Hi @JuliusFreudenberger , thanks for your work on this - I can confirm the pushTAN 2.0 is now working with the latest release.

Were you able to work around the issue of having to manually confirm pushTAN on every import? There has to be a solution as it works fine for 90 days on other (paid) platforms once a device is added as "trustworthy"

JuliusFreudenberger commented 2 months ago

As you opened #149, I will answer there.