search

bnw / firefly-iii-fints-importer

Import financial transactions from you FinTS enabled bank into Firefly III.
GNU Affero General Public License v3.0
156 stars 23 forks source link

Add Tag to all imported transactions #20

Open cdrfun opened 4 years ago

cdrfun commented 4 years ago

Similar to the CSV importer a tag for every import shall be created and applied to all imported transactions. This helps to identify problems and revert wrong imports

kevinkk525 commented 4 years ago

I'm currently a bit "afraid" of using this great importer because if the import is messed up (e.g. too many transactions imported) I would need to hunt down every wrong transaction because I can't just delete all transactions by its tag. I think it would be great to get a tag for every import.

totti4ever commented 4 years ago

Okay, after using it a bit, I have to admit: This would help heaps to try it out and clean up in case of unwanted things!!

bnw commented 4 years ago

I added some code that adds a tag containing a timestamp to all the imported transactions (i.e. using the https://api-docs.firefly-iii.org/#/transactions/storeTransaction endpoint and filling the tags-field).

The problem now is that firefly's duplicate checking does no longer work. Apparently this check does include the tags of the transaction. So if I run the importer twice, I end up with duplicate transactions that only differ in their tags.
@JC5 Do you have any idea on how to solve this? Maybe firefly should exclude the tags when comparing transactions? Or could there be an option to do so?

JC5 commented 4 years ago

The other Firefly III importers solve this by adding the tag after the import is complete.

bnw commented 4 years ago

Ah, many thanks. :)

retarepo commented 1 month ago

Hello, I just bumped into this issue because the auto-tagging feature is for me a must-have as well. Although this issue is almost ancient and seem to be worked on, I do not find any reference to a auto-tagging feature anywhere in the repository, but this issue (using the search function of github). So my question: is it somehow possible to activate or just got buried in time?

bnw commented 1 month ago

Hi @retarepo, sadly, this feature never got implemented. I'm open to pull requests tho :)