bo-yang / plan9front

Automatically exported from code.google.com/p/plan9front
0 stars 0 forks source link

mothra issues #92

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Broken:

- Mouse button 2 to display the current URL is ignored.
- The keyboard command q to quit is ignored.
- URLs beginning with ftp:// do not work, in spite of what it says in webfs(4). 
Mothra provides the following error message: "'/mnt/web/0/body' unsupported url 
type"
- Pop-up windows triggered by HTTP BASIC AUTH cause factotum to print to the 
rio window behind mothra. (Login via form input works fine, even via https.)
- Login redirection at some sites results in an endless loop. (Examples: 
ebay.com, tumblr.com.) 

Wishlist:

- Collapse/Expand navigation boxes keyboard command.
- Back/Forward keyboard commands and/or menu options.
- Menu option or mouse button action to plumb images and links. Proposal: move 
the menu to mouse button 2 and use mouse button 3 to plumb, consistent with 
acme. The current man page description of using mouse button 2 to display the 
current URL is redundant since it is already displayed in the Url: box.

Advanced Usage:

- With plumbing enabled, scripting more complex usage models such as "tabbed 
browsing" could be trivially enabled through the use of winwatch(1), window(1) 
and shell scripts.

Original issue reported on code.google.com by stanley....@gmail.com on 23 Sep 2011 at 4:07

GoogleCodeExporter commented 9 years ago
Revision 39cbe398ff17 fixes ebay.com login.
Revision 71548e5996 fixes tumblr.com login.

Original comment by stanley....@gmail.com on 23 Sep 2011 at 3:21

GoogleCodeExporter commented 9 years ago
Not really broken:

- Mouse button 2 to display the current URL works in the navigation box under 
the Go: field.
- The keyboard command q to quit must be followed by hitting enter.

Original comment by stanley....@gmail.com on 23 Sep 2011 at 3:22

GoogleCodeExporter commented 9 years ago
Revision 6fb4d5c739 adds keyboard command a to collapse/expand navigation boxes.

Original comment by stanley....@gmail.com on 23 Sep 2011 at 4:06

GoogleCodeExporter commented 9 years ago
Broken:

- $home/lib/mothra/mothra.log is created, but never updated with a log of 
visited URLs.

Original comment by stanley....@gmail.com on 23 Sep 2011 at 9:57

GoogleCodeExporter commented 9 years ago
Revision edcd392145 adds keyboard command j to jump to a page from the list of 
previously viewed pages.

Original comment by stanley....@gmail.com on 24 Sep 2011 at 3:55

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Wishlist:

- Home, end, pgup, pgdn should behave the same as in sam/acme.

Revised Proposal:

- After clicking a link or image with mouse button 2, the "snarf url" menu 
option already snarfs the URL of the clicked object. Rather than moving the 
menu to mouse button 2 and making mouse button 3 plumb, just add Plumb as a 
menu option.

Original comment by stanley....@gmail.com on 24 Sep 2011 at 6:12

GoogleCodeExporter commented 9 years ago
Broken:

- From getpix.c:

char *pixcmd[]={
[GIF]   "gif -9t",
[JPEG]  "jpg -9t",
[PNG]   "png -9t",
[PIC]   "fb/3to1 /lib/fb/cmap/rgbv",
[TIFF]  "/sys/lib/mothra/tiffcvt",
[XBM]   "fb/xbm2pic",
};

The pic, tiff and xbm viewers don't exist on the system.

Original comment by stanley....@gmail.com on 25 Sep 2011 at 2:06

GoogleCodeExporter commented 9 years ago
Broken:

- Clicking on direct links to non-HTML files such as .gif, .jpg, .png, .pdf, 
etc., is supposed to launch an external viewer program (hardcoded in geturl()) 
using filter(). For images and .pdf files, page(1) is launched, but complains 
either that the image type is invalid or, for .pdf files, displays only the 
list of page numbers in the menu. Page(1) handles the same files without 
problems when run manually on the command line.

Original comment by stanley....@gmail.com on 25 Sep 2011 at 7:48

GoogleCodeExporter commented 9 years ago
Revision 0c01ad7cab adds pgup, pgdn, home and end.

Broken:

- Home and end are an ugly hack and do not work on long files. This should be 
fixed.

Original comment by stanley....@gmail.com on 26 Sep 2011 at 3:52

GoogleCodeExporter commented 9 years ago
Revision f6eeb4b44a fixes home, end.

Revision 16c04288f5 fixes opening direct links to .gif, .jpg, .png, .pdf, etc.

Original comment by stanley....@gmail.com on 26 Sep 2011 at 2:28

GoogleCodeExporter commented 9 years ago
excellent bug report :-)

i can explain the auth problem:

mothra uses webfs and webfs uses factotum to get the
password. it probably should not use the default getkey
method wich will prompt you on the console webfs is
running.

instead, it should not ask for any keys at all and rely
on auth/fgui to query the keys from the user.

i tried this out and i found some problems in factotum
and fgui that are now fixed.

the only thing i didnt fix where fguis ugly user
interface and the absense of a dismiss mechanism.

might be a good idea to rewrite fgui as a rc script?

all it really needs todo is raise a rio window and
prompt for the missing keys. factotum itself can be
called as a key query program so all we need is a
little bit of plumbing.

anyway, continue please :)

Original comment by cinap_le...@felloff.net on 27 Sep 2011 at 2:21

GoogleCodeExporter commented 9 years ago
hm, wait, that makes no sense. webfs doesnt pass a
getkeys argument at all. so whos asking for passwords?

Original comment by cinap_le...@felloff.net on 27 Sep 2011 at 2:51

GoogleCodeExporter commented 9 years ago
This is the message printed behind the mothra screen:

webfs: Authentication failed: needkey !password? proto=pass realm=USER 
server=thegreen.stanleylieber.com service=http user?

Original comment by stanley....@gmail.com on 27 Sep 2011 at 2:54

GoogleCodeExporter commented 9 years ago
Revision 32c7356592 adds menu option to save url.

Original comment by stanley....@gmail.com on 27 Sep 2011 at 5:56

GoogleCodeExporter commented 9 years ago
After the latest changes, the pop-up login box for HTTP BASIC AUTH that used to 
be printed behind mothra now appears at the very top of the browser, above the 
Go: box:

'/mnt/web/5/body' needkey !password? proto=pass realm=USER 
server=thegreen.stanleylieber.com

Original comment by stanley....@gmail.com on 27 Sep 2011 at 9:18

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Revision 184b74d442aa causes images that are not also links to be displayed as 
a link to themselves. It also adds moth mode for saving images and links.

Original comment by stanley....@gmail.com on 2 Oct 2011 at 2:35

GoogleCodeExporter commented 9 years ago
Revision 184b74d442aa also removes the save url menu option, which was made 
redundant by the addition of moth mode.

Original comment by stanley....@gmail.com on 2 Oct 2011 at 2:36

GoogleCodeExporter commented 9 years ago
Revision 60b1415a4f adds <input type="search">, fixes wikipedia form submission.

Original comment by stanley....@gmail.com on 3 Oct 2011 at 1:59

GoogleCodeExporter commented 9 years ago
Revision 00c77a65d0 changes <p> tag rendering: do not indent, insert a blank 
line between paragraphs.

Original comment by stanley....@gmail.com on 3 Oct 2011 at 2:00

GoogleCodeExporter commented 9 years ago
Revision d391fa010c causes <input type=""> to default to text if it has 
no/invalid value.

Broken:

- <input type="file"> is not currently handled.

Original comment by stanley....@gmail.com on 3 Oct 2011 at 2:43

GoogleCodeExporter commented 9 years ago
Revision a9d7eec70b81 ignores content-type and introduces content sniffing. 
This fixes clicking many file types to open in page(1).

Original comment by stanley....@gmail.com on 3 Oct 2011 at 6:49

GoogleCodeExporter commented 9 years ago
Revision d022f1b19d changes the external viewer for .gif files. When clicked, 
animated .gif files (that are not also links) are displayed, animated.

Original comment by stanley....@gmail.com on 4 Oct 2011 at 11:16

GoogleCodeExporter commented 9 years ago
Broken:

- The menu option paste puts text into the Go: box no matter where you left the 
(invisible) cursor.

Original comment by stanley....@gmail.com on 5 Oct 2011 at 12:02

GoogleCodeExporter commented 9 years ago
Broken:

- If a URL has been selected or a file has been saved in moth mode on the 
current page, saving the current page to the hit list results in a blank link.

- As of yesterday, the reblog form at tumblr.com worked. As of today, clicking 
submit on the reblog form causes mothra to crash. The problem is reproducible. 
Here are three examples of the output produced by running mothra -dv and 
attempting to reblog a post:

  mothra 143011: suicide: sys: trap: fault read addr=0x0 pc=0x00002a53
  mothra 145180: suicide: sys: trap: fault read addr=0x0 pc=0x00002a53
  mothra 149556: suicide: sys: trap: fault read addr=0x0 pc=0x00002a53

- 

Original comment by stanley....@gmail.com on 5 Oct 2011 at 3:05

GoogleCodeExporter commented 9 years ago
can you run acid on the broken processes and do a stacktrace?

Original comment by cinap_le...@felloff.net on 6 Oct 2011 at 11:43

GoogleCodeExporter commented 9 years ago
http://okturing.com/src/828/body

Original comment by stanley....@gmail.com on 7 Oct 2011 at 3:53

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
#r54a014d669b2

Original comment by cinap_le...@felloff.net on 7 Oct 2011 at 4:46

GoogleCodeExporter commented 9 years ago
Revision 53f8cd4a73fc in mothmode, insert artificial links to href target for 
images that are also links. this allows snarfing either the href url or the url 
of the image itself.

Original comment by stanley....@gmail.com on 9 Oct 2011 at 2:45

GoogleCodeExporter commented 9 years ago
Broken:

- Animated images (.gif, .png) do not display animated in the browser.

Original comment by stanley....@gmail.com on 11 Oct 2011 at 1:46

GoogleCodeExporter commented 9 years ago
for the animated gifs, i think thats a feature. :)

Original comment by cinap_le...@felloff.net on 19 Oct 2011 at 5:22

GoogleCodeExporter commented 9 years ago
Broken:

- No attempt is made to render <table>, <th>, <tbody>, <tr>, <td> properly.

Thoughts:

- All of these tags used to compose the layout of pages (<table>, <div>, 
<span>, etc.) are presently ignored. The result is that when displayed in 
mothra, the elements of many pages are all smashed together in a sometimes 
difficult to read fashion. Should we: 1.) continue to ignore them, 2.) treat 
them as a <p> and insert whitespace between them and the adjacent content, 3.) 
something else?

Original comment by stanley....@gmail.com on 19 Oct 2011 at 2:13

GoogleCodeExporter commented 9 years ago
theres nothing wrong with interpreting these tags in a way that untangles the
text saucage currently produced.

as long as one doesnt fall into the trap of attempting "correct" rendering here,
wich is no good fit for the rtextview used by mothra.

maybe take a look at how htmlfmt handles these tags.

Original comment by cinap_le...@felloff.net on 19 Oct 2011 at 4:36

GoogleCodeExporter commented 9 years ago

Original comment by cinap_le...@felloff.net on 4 Nov 2011 at 11:04

GoogleCodeExporter commented 9 years ago
Revision c5ab28aa35 adds cut/snarf for form input fields.

Original comment by stanley....@gmail.com on 8 Nov 2011 at 1:23

GoogleCodeExporter commented 9 years ago
Revision e385db2866 treats <div> as <p>.

Original comment by stanley....@gmail.com on 8 Nov 2011 at 7:44

GoogleCodeExporter commented 9 years ago
Revision 51d2b921ce thinks better and treats <div> as <br>.

Original comment by stanley....@gmail.com on 8 Nov 2011 at 8:08

GoogleCodeExporter commented 9 years ago
After surfing tumblr for a while I consistently hit "Can't load image" errors 
that don't resolve until I kill and restart mothra.

Stack traces:

http://okturing.com/src/886/body

Original comment by stanley....@gmail.com on 12 Nov 2011 at 5:34

GoogleCodeExporter commented 9 years ago
grep didnt find this error message in:
libdraw/*.c libmemdraw/*.c cmd/jpg/*.c cmd/mothra/*.c cmd/mothra/libpanel/*.c

it sounds like you'r running out of image memory. can you cat /dev/swap
and tell the values for "kernel draw"?

Original comment by cinap_le...@felloff.net on 12 Nov 2011 at 7:37

GoogleCodeExporter commented 9 years ago
Revision 7f346b064584
limits the amount of image data in devdraw to 8MB, can
be changed in mothra.h by setting NPIXMB.

Original comment by cinap_le...@felloff.net on 14 Nov 2011 at 12:10

GoogleCodeExporter commented 9 years ago
Revision 49e1b2980c fixes a problem with webfs and cookies.

Original comment by stanley....@gmail.com on 17 Nov 2011 at 2:07

GoogleCodeExporter commented 9 years ago
Broken:

- Scrollwheel/nub does not scroll.

Original comment by stanley....@gmail.com on 8 Dec 2011 at 5:21

GoogleCodeExporter commented 9 years ago
Broken:

- Since Revision 7f346b064584, returning to a previously loaded page by 
clicking in the history window displays the page sans any of its images. After 
manually reloading the page the images are once again displayed.

Original comment by stanley....@gmail.com on 8 Dec 2011 at 5:46

GoogleCodeExporter commented 9 years ago
Revision a750bae4eb2c adds linkify.

Original comment by stanley....@gmail.com on 4 Mar 2012 at 5:53

GoogleCodeExporter commented 9 years ago
Revision 0d4ad5c5b996 fixes scrollwheel/nub scrolling.

Original comment by stanley....@gmail.com on 4 Mar 2012 at 5:55

GoogleCodeExporter commented 9 years ago
Ideas:

- 'f' command to highlight all links and prefix them with a number. While in 
'f' mode, links are followed by typing the corresponding number and hitting 
enter.

- 'm' command to enter (and leave) moth mode. If 'f' mode has already been 
engaged, the numbers presented shall correspond to the respective actions 
offered by moth mode.

Original comment by stanley....@gmail.com on 22 Mar 2012 at 1:28

GoogleCodeExporter commented 9 years ago
Broken:

- Links that span multiple words are presented underlined, but with 
non-underlined spaces between each word. This makes it cumbersome to determine 
the number of separate URLs linked by the multi-word phrase.

Original comment by stanley....@gmail.com on 22 Mar 2012 at 1:31

GoogleCodeExporter commented 9 years ago
Revision 79b1d9c8cfaf adds the 'm' command.

Original comment by stanley....@gmail.com on 23 Mar 2012 at 2:03