bo3b / 3Dmigoto

Chiri's DX11 wrapper to enable fixing broken stereoscopic effects.
Other
688 stars 109 forks source link

Change DX9 to use fonts without licensing issues #157

Open Nintynuts opened 2 years ago

Nintynuts commented 2 years ago

Originally posted by @DarkStarSword in https://github.com/bo3b/3Dmigoto/issues/156#issuecomment-1128375252

[...] some potential licensing concerns over the use of 3rd party font rendering code that I was trying to determine if it could be a problem / potentially incompatible with GPL (for our community it is unlikely to be a problem as IIRC the code seems to have been released openly with intent for anyone to use, however if memory serves it was released without a defined license on some random internet forum (IIRC it was a cheater community, odd place to release it) and was vaguely derived from Microsoft example code found in an ancient DX SDK... the lack of clarity on the licensing situation on that code would be of concern to any companies planning to release a version of 3DMigoto and would probably need to run it by their IP lawyers first), and I think there was also 3rd party code included that I traced back to GeDoSaTo that effectively removed our compatibility with MIT (pretty sure I already committed the removal of MIT to the license file), making 3DMigoto GPL only (unless we decide to drop/replace that code before next release).

Originally posted by @bo3b in https://github.com/bo3b/3Dmigoto/issues/156#issuecomment-1129456222

[Using DirectXTK] would alleviate needing the font library here. The goal of adding DirectXTK was as a set of libraries to provide some basic functions like font rendering and screen shots that are boilerplate stuff. I have not looked closely at what Dave brought in for DX9 subproject.

Pretty much agree this licensing won't fly for our upcoming stuff, but is probably fine for HelixMod use.

Originally posted by @DarkStarSword in https://github.com/bo3b/3Dmigoto/pull/156#issuecomment-1129537740

FWIW since the 3rd party code is only used in the DX9 project we do still have the option of releasing the DX11 project under MIT, though this could be confusing if we have different releases of 3DMigoto under different licenses. I do have some preference to replacing the DX9 font rendering library and dropping GeDoSaTo code so we can revert to the previous dual MIT+GPL license for all projects.

Also mentioned in DSS's todo list

I made an issue in the DirectXTK asking about potential DX9 compatibility, and changes have been made.

It sounds like @davegl1234 may have alternative code to GeDoSaTo which was also being used for cursor/upscaling hooking #158, which may make removing this dependency easier.