search

bo3b / 3Dmigoto

Chiri's DX11 wrapper to enable fixing broken stereoscopic effects.
Other
770 stars 122 forks source link

Add "drawindexedinstanced = auto" #161

Closed eArmada8 closed 1 year ago

eArmada8 commented 2 years ago

Hi, I'd like to submit a pull request. Kuro no Kiseki (Clouded Leopard Entertainment, Steam) uses the DrawIndexedInstanced command instead of the DrawIndexed command, and using "drawindexed = auto" results in certain meshes disappearing at various camera angles. I implemented drawindexedinstanced = auto in the DX11 command list. Thank you!

DarkStarSword commented 1 year ago

Sorry that it's taken so long for me to get around to this. I've flattened the history a little to remove the rewrite + revert commits as that could cause issues for merging into other forks and confuse git blame.

Also merged this into geo-11 (though I wouldn't recommend geo-11 for non-stereo 3D modding just yet, but some day when it's as stable as 3DMigoto...). Not entirely sure when the next 3DMigoto release will be given that most effort is on geo-11 now, but given that geo-11 still has a lot of catching up to do in terms of stability it's probably worth doing another 3DMigoto release at some point.

For my own future reference I used Green Hell to test this functionality, as that uses instanced draw calls for many plants, etc. Has some issues in geo-11 with force_stereo=2 and crashes on reload, but those are unrelated geo-11 problems - works fine in 3DMigoto.

eArmada8 commented 1 year ago

Thank you very much! Also thank you for flattening the commits, it's embarrassing how little I understood github and best practices (I still don't).