boa-dev / boa-dev.github.io

Home of the Boa blog
https://boajs.dev/
3 stars 3 forks source link

Add aria-label and grid header on test hover #152

Closed nekevss closed 3 months ago

nekevss commented 4 months ago

This is related to #148. Added the aria-label property so that it should display the title on hover. Tested on Firefox and Brave :smile:

jedel1043 commented 4 months ago

Hmm, just wondering if this counts as misusing aria-label, since this is not using it for accessibility, but to implement a UX feature.

nekevss commented 4 months ago

That was mostly the idea of adding the aria-label for hover was for the accessibility, and hopefully to make the test grid more accessibility friendly.

There's a couple other approaches that I can think of off the top of my head:

  1. Add a card component that disables on hover for the tests. I'm not entirely sure if that's any friendlier accessibility wise.
  2. Update the card header to include the test. I.e. Header: ArrayBuffer -> ArrayBuffer - name.js