search

boa-dev / boa

Boa is an embeddable and experimental Javascript engine written in Rust. Currently, it has support for some of the language.
MIT License
5.07k stars 400 forks source link

Add Boa to Test262-Harness #3431

Open jasonwilliams opened 11 months ago

jasonwilliams commented 11 months ago

Boa being part of Test262-Harness will make it easier to test which parts of TEST262 Boa has implemented. Currently it's not easy to do this. There are a few dependencies Boa needs to be added to before this can happen.

Test262-harness uses eshost which uses esvu. Boa support would need to be added to these repositories.

linusg commented 3 months ago

Upstream eshost and test262-harness are effectively unmaintained, so test262.fyi uses these two forks:

@CanadaHonk added boa support to the eshost fork, test262-harness doesn't need any additional changes.

jasonwilliams commented 3 months ago

This is good to know and thanks for adding Boa to these forks.

My concern though is that the TC39 champions are still using the original version. Last time I spoke to Temporal champions they were using Brian’s harness, it’s also listed here on the test262 page. https://github.com/tc39/test262?tab=readme-ov-file#test262-runners

Is it possible to make @canadaHonk’s version the canonical version by asking on there? Or I can ask if you don’t want to. We should just have everyone use this one if it’s more actively maintained

CanadaHonk commented 3 months ago

Fwiw, I haven't fully tried to get my changes upstream as those were originally mostly intended as a fork for test262.fyi specifically before I knew upstream was inactive. I believe they are still usable standalone like the original though, so I'm happy for my forks to become canonical if wanted.

jasonwilliams commented 3 months ago

For what it’s worth, I don’t think it makes sense to even try upstreaming your changes at this point. The upstream version hasn’t been maintained in years and Brian isn’t as active as he was before either.

Effort is better spent moving to your version (updating docs etc), but that’s just my opinion.

jasonwilliams commented 3 months ago

Upstream eshost and test262-harness are effectively unmaintained, so test262.fyi uses these two forks:

@CanadaHonk added boa support to the eshost fork, test262-harness doesn't need any additional changes.

Does Boa need adding to the readme if it’s supported in https://github.com/CanadaHonk/eshost ?