search

boa-dev / boa

Boa is an embeddable and experimental Javascript engine written in Rust. Currently, it has support for some of the language.
MIT License
4.92k stars 389 forks source link

Split `boa_tester` into crates #3696

Open jedel1043 opened 4 months ago

jedel1043 commented 4 months ago

Now that temporal_rs is a thing, we need a way to test it against test262. We could reimplement boa_tester but it would be better to extract the test extraction part from the test runner, and then reuse that for temporal_rs.

PawelJastrzebski commented 4 months ago

Hi, I would like to contribute. Could you tell me if I'm going in the right direction?

I'm not sure if I'm understanding use case for this new crate, you want to extract all parsing logic from boa_tester to another crate so extraction/parsing logic could be reused. I'm not sure if I understand "extraction part" correctly.

image test262-parser (todo typo) representing new crate

jedel1043 commented 4 months ago

@PawelJastrzebski Thank you for the help! Yeah, that was mostly the idea: separate the test262 parser from the main program. Though, I'd recommend also including the git module inside test262_parser, maybe with some interface to be able to either download the repo or pass a manual path to a valid test262 directory.

PawelJastrzebski commented 2 weeks ago

Hello, @jedel1043. Could you take a look at PR #3708. It's probably not perfect, but I guess it's step in right direction. So even if it happen not to close this issue, maybe it could be merged at this stage, as it easier to maintain/merge and review smaller batches of changes.