search

boa-dev / boa

Boa is an embeddable and experimental Javascript engine written in Rust. Currently, it has support for some of the language.
MIT License
4.82k stars 385 forks source link

Adding TryFromJs implementations for tuples #3843

Closed hansl closed 2 weeks ago

hansl commented 2 months ago

This make it easier to get the first N values from an array when de-serializing.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.78%. Comparing base (6ddc2b4) to head (9008f22). Report is 179 commits behind head on main.

Files Patch % Lines
...engine/src/value/conversions/try_from_js/tuples.rs 50.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3843 +/- ## ========================================== + Coverage 47.24% 50.78% +3.53% ========================================== Files 476 470 -6 Lines 46892 45347 -1545 ========================================== + Hits 22154 23028 +874 + Misses 24738 22319 -2419 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hansl commented 2 months ago

No idea why the Windows action is failing.

nekevss commented 1 month ago

If you rebase the CI should be fixed :smile: There was an issue that was fixed with #3845.