search

boa-dev / boa

Boa is an embeddable and experimental Javascript engine written in Rust. Currently, it has support for some of the language.
MIT License
5.04k stars 399 forks source link

Bump temporal_rs to latest commit #3880

Closed jedel1043 closed 3 months ago

jedel1043 commented 3 months ago

Will have to publish a new version for temporal_rs before publishing 0.19, but this at least integrates with the new features.

github-actions[bot] commented 3 months ago

Test262 conformance changes

Test result main count PR count difference
Total 50,771 50,213 -558
Passed 43,015 42,981 -34
Ignored 1,411 1,411 0
Failed 6,345 5,821 -524
Panics 19 0 -19
Conformance 84.72% 85.60% +0.87%
Fixed tests (1): ``` test/built-ins/Temporal/PlainTime/prototype/add/argument-string-negative-fractional-units.js (previously Failed) ```
Fixed panics (19): ``` test/built-ins/Temporal/Duration/prototype/round/smallestunit-plurals-accepted-string.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/largestunit-wrong-type.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/roundingincrement-wrong-type.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/round-negative-result.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/subclassing-ignored.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/roundingincrement-undefined.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/smallestunit-wrong-type.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/roundingmode-undefined.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/smallestunit-string-shorthand-string.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/largestunit-smallestunit-combinations.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/relativeto-number.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/order-of-operations.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/largestunit-undefined.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/smallestunit-undefined.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/round-cross-unit-boundary.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/balance-subseconds.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/balance-negative-result.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/relativeto-undefined-throw-on-calendar-units.js (previously Panic) test/built-ins/Temporal/Duration/prototype/round/roundingmode-wrong-type.js (previously Panic) ```
jedel1043 commented 3 months ago

Checked the tests and they're a regression from temporal_rs. Will try to patch it there. (https://github.com/boa-dev/temporal/pull/57)