search

boa-dev / criterion-compare-action

⚡️📊 Compare the performance of Rust project branches
ISC License
63 stars 26 forks source link

`cargo install critcmp` installs if install is cached by CI runner #104

Open juntyr opened 1 year ago

juntyr commented 1 year ago

Perhaps the action could first check if cargo critcmp exists and only if that fails run the installation? Thanks for your help!

Here's the error log:

2023-08-21T03:31:39.5650135Z ##[group]Run boa-dev/criterion-compare-action@v3
2023-08-21T03:31:39.5650424Z with:
2023-08-21T03:31:39.5651056Z   branchName: master
2023-08-21T03:31:39.5651854Z   token: ***
2023-08-21T03:31:39.5651960Z   defaultFeatures: true
2023-08-21T03:31:39.5652052Z ##[endgroup]
2023-08-21T03:31:39.6729665Z [command]/home/runner/.cargo/bin/cargo install critcmp
2023-08-21T03:31:39.7747230Z     Updating crates.io index
2023-08-21T03:31:39.9570372Z error: binary `critcmp` already exists in destination
2023-08-21T03:31:39.9570853Z Add --force to overwrite
2023-08-21T03:31:39.9589680Z Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
2023-08-21T03:31:39.9590262Z     at ExecState._setResult (/home/runner/work/_actions/boa-dev/criterion-compare-action/v3/dist/index.js:1:24691)
2023-08-21T03:31:39.9590917Z     at ExecState.CheckComplete (/home/runner/work/_actions/boa-dev/criterion-compare-action/v3/dist/index.js:1:24251)
2023-08-21T03:31:39.9592134Z     at ChildProcess.<anonymous> (/home/runner/work/_actions/boa-dev/criterion-compare-action/v3/dist/index.js:1:23092)
2023-08-21T03:31:39.9592652Z     at ChildProcess.emit (node:events:513:28)
2023-08-21T03:31:39.9592929Z     at maybeClose (node:internal/child_process:1100:16)
2023-08-21T03:31:39.9593253Z     at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)
2023-08-21T03:31:39.9616420Z ##[error]Unhanded error:
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101