boakley / robotframework-hub

Web app for accessing robot framework assets
https://github.com/boakley/robotframework-hub/wiki
Apache License 2.0
170 stars 60 forks source link

create separate vendor directory for 3rd party assets #19

Closed yanne closed 10 years ago

yanne commented 10 years ago

I started to play around with some enhancements to search. This means writing own javascript, which I think should be separated from 3rd party files. With flask, it's easiest to put the own js sources under static also. Thus put the vendor files under vendor/ dir.

yanne commented 10 years ago

I actually first missed the possibility to have blueprint specific static files under the blueprints themselves. However, there might still be reason to have application wide helper code under rfhub/static/

boakley commented 10 years ago

Thanks, Yanne!

I need to think about this. While I like the idea of separating out vendor-specific stuff, I almost think it makes more sense to have a slightly different layout. For example, instead of static/vendor/css/bootstrap... and static/vendor/js/jquery/..., we eliminate the css and js folders. For example, have /static/vendor/jquery, /static/vendor/bootstrap, etc. This makes it easier to upgrade because we can just dump vendor code in one place without having to separate it all out into javascript and css.

Thoughts?

yanne commented 10 years ago

that might also make sense, although it makes it a bit more cumbersome to add js libraries that are distributed as a single minified js file. One additional option would be to use a tool like browserify to manage the dependencies, although that might be overkill at this point.

yanne commented 10 years ago

Actually, I will close this issue and do a separate PR for the last two commits (which are useful on their own)

We can decide on rfhub/static structure later when the decision is actually needed.