search

boakley / robotframework-hub

Web app for accessing robot framework assets
https://github.com/boakley/robotframework-hub/wiki
Apache License 2.0
169 stars 60 forks source link

Replaced Pageobjects with more generalized option -M/--modules #55

Closed charleshamel73 closed 8 years ago

charleshamel73 commented 8 years ago

Purpose: I noticed that when using custom modules structure like pageobjects that the pageobject argument does not work. This change should work to remove the dependency on robotpageobjects while still allowing the ability for mass imports from a module. Also included is one new test for the parameter help menu and updated tests to match new framework changes.

Itemized Changes: Added Import Error Message to the "unable to load library' message Switched Parameter -O or --pageobjects With Parameter -M/--module for clarity Changed Name of PageObjectAction to ModuleAction for Clarity and updated documentation Removed import from robotpageobjects and check for subclass Appended error message to "unable to import " message Added Test for new parameter help menu Updated old test to match new framework results Added "r" in SUITE_DIR Evaluate to fix issue with "\" causing bad path

boakley commented 8 years ago

Thanks, Charlie! Sorry it took so long to get it merged in.

charleshamel73 commented 8 years ago

It's no problem Bryan. How yah been? Also, Matt and I finally posted up our pageobjects library. https://github.com/charleshamel73/robot-pageobjects

boakley commented 8 years ago

Oh no! I mean, that's great!

Unfortunately I'm going to be posting a page object library soon, too. I don't want to rain on your parade :-\ I guess choice is good, but now there are going to be three page object libraries out there. Though, the original one I think is going to be left in the dust since the developer seems to have abandoned it.

On Sun, Mar 27, 2016 at 10:39 AM, charleshamel73 notifications@github.com wrote:

It's no problem Bryan. How yah been? Also, Matt and I finally posted up our pageobjects library. https://github.com/charleshamel73/robot-pageobjects

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub https://github.com/boakley/robotframework-hub/pull/55#issuecomment-202092572

charleshamel73 commented 8 years ago

Yeah. Well I'm interested in seeing how you coded yours. I remember all the issues with developing the library so I'm interested how you worked around them.