search

boardfish / com3502-assignment

Voice changer program in Pure Data.
0 stars 0 forks source link

an ability to reset the phase of the oscillator when speed = 0 in order to ensure consistent output when initialising/resetting #6

Closed boardfish closed 4 years ago

boardfish commented 4 years ago

Hey @kyenqiu, I've just had a look at what you just uploaded. Were you trying to fix #5? I've left you some tips on how to do this over on that issue.

kyenqiu commented 4 years ago

Yes, I still working on it.

Simon Fish notifications@github.com于2019年12月14日 周六17:31写道：

Hey @kyenqiu https://github.com/kyenqiu, I've just had a look at what you just uploaded. Were you trying to fix #5 https://github.com/boardfish/speech-main-assignment/issues/5? I've left you some tips on how to do this over on that issue.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/boardfish/speech-main-assignment/issues/6?email_source=notifications&email_token=AMTTXBXQZKZ3I2IUFWKETN3QYUKADA5CNFSM4JZNSBV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG4HKDA#issuecomment-565736716, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTTXBV4K34DFNRNEFBPHQTQYUKADANCNFSM4JZNSBVQ .

boardfish commented 4 years ago

By the way, if you're struggling with this issue, it might be wise to drop it and pick up #9 and/or #19 instead, as I expect they'll be much more straightforward.

kyenqiu commented 4 years ago

Hi Simon , I think you’re right. Just use LFO~.help check what I upload.

Simon Fish notifications@github.com于2019年12月14日 周六17:43写道：

By the way, if you're struggling with this issue, it might be wise to drop it and pick up #9 https://github.com/boardfish/speech-main-assignment/issues/9 and/or #19 https://github.com/boardfish/speech-main-assignment/issues/19 instead, as I expect they'll be much more straightforward.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/boardfish/speech-main-assignment/issues/6?email_source=notifications&email_token=AMTTXBX3MWAQOSZZYNXCEALQYULLHA5CNFSM4JZNSBV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG4HQFY#issuecomment-565737495, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTTXBVBOPGW4UHPBGKVN53QYULLHANCNFSM4JZNSBVQ .

boardfish commented 4 years ago

Yep, looks like your work only tries to fix #5. I'll leave this open and try to do it myself at some point.

boardfish commented 4 years ago

Found something that'd be helpful:

osc~-help

This is from osc~-help.pd. I'd suggest using a spigot to pass speed to the right inlet if it is 0.

boardfish commented 4 years ago

Yep, looks like your work only tries to fix #5. I'll leave this open and try to do it myself at some point.

Also, this seems nice and straightforward - I'll probably do it dead last if we're out of time, so it's yours for the taking if you're up to it.