Closed Izhaki closed 4 years ago
This is a good idea. Game
does do some initialization work, but Client
and Server
can just call Game
internally and it would be a pretty simple change to implement.
Do you have time to make a PR for this?
Guess I could.
How do you envision it? Mainly:
game
be allowed to be either the result of Game()
or just plain object (as determined by looking at the processMove
prop)?Game()
was called?Let's just make a clean break and move over to the new proposed version.
We're still in alpha so people should expect breaking changes. As long as we document it clearly in the changelog, things should be fine.
This was fixed as part of the "phases-overhaul" effort.
But still...
From the docs:
Why do we need to import
Game
and call it?Why not just:
And have
Client
invokingGame
?I've looked throughout the docs and couldn't find why not doing it this way.