search

boardgameio / boardgame.io

State Management and Multiplayer Networking for Turn-Based Games
https://boardgame.io
MIT License
9.93k stars 707 forks source link

Fails to build with node v12 #463

Closed haoyangnz closed 4 years ago

haoyangnz commented 4 years ago

Fails to build grpc@1.20.0 (see https://github.com/grpc/grpc-node/issues/834)

$ npm i

node-pre-gyp WARN Tried to download(404): https://node-precompiled-binaries.grpc.io/grpc/v1.20.0/node-v72-darwin-x64-unknown.tar.gz 
node-pre-gyp WARN Pre-built binaries not found for grpc@1.20.0 and node@12.10.0 (node-v72 ABI, unknown) (falling back to source compile with node-gyp) 

...

../ext/channel.cc:292:56: error: too few arguments to function call, expected 2, have 1
  int try_to_connect = (int)info[0]->Equals(Nan::True());
$ npm-why grpc
  boardgame.io > firebase > @firebase/firestore > grpc@1.20.0
  boardgame.io > firebase-admin > @google-cloud/firestore > google-gax > grpc@1.20.0
  boardgame.io > firebase-admin > @google-cloud/firestore > google-gax > grpc-gcp > grpc@1.20.0

Can we upgrade firebase?

nicolodavis commented 4 years ago

Yes, of course. Feel free to send me a PR.