search

boardgamers / gaia-engine

Javascript engine for project gaia
MIT License
13 stars 6 forks source link

Bug in Gleens +2vp for Gaia #180

Closed rzulian closed 6 years ago

rzulian commented 6 years ago

Game https://gaiaform.io/game/Gianluigi-Buffon Gleens have now 65vp If you play the game locally the have 55vp. They are receiving +2vp for a gaia planet. This is the log in the site

screen shot 2018-10-11 at 21 48 28

this is the log locally

screen shot 2018-10-11 at 21 48 07

Any clue?

coyotte508 commented 6 years ago

Uh.

https://gaiaform.io/game/timid-front-3625

This is a current game, they don't get the points

rzulian commented 6 years ago

FOr Gianluigi-Buffon I’ve to update the ungine with the oldGames

On 11 Oct 2018, at 22:06, coyotte508 notifications@github.com wrote:

Uh.

https://gaiaform.io/game/timid-front-3625 https://gaiaform.io/game/timid-front-3625 This is a current game, they don't get the points

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/donkeytech/gaia-engine/issues/180#issuecomment-429099822, or mute the thread https://github.com/notifications/unsubscribe-auth/AcjgpHc_iPKdgMNTRtLgATzqKEd_DgDsks5uj6TKgaJpZM4XYQNE.

coyotte508 commented 6 years ago

The issue can probably be explained by the fact that gleens gaining victory points used to be an event as starting income in the faction board, and now it's through a handler: https://github.com/donkeytech/gaia-engine/commit/6d4d9c45133f4886a309ef1ec2f58655af83aa61#diff-abb8c3287ffe29a9a1f3703fd380d62e

This was changed to enable tracking the income as faction income ("gleens")

Games ongoing during the switch would have both. It doesn't explain why in https://gaiaform.io/game/timid-front-3625, before I replayed, gleens didn't get points for planets on gaia.

rzulian commented 6 years ago

@coyotte508 : I've created v2.5.6 to manage Gianluigi-Buffon, but I cannot replay it because I'm getting the same error from the site. I think is about the EngineOptions

coyotte508 commented 6 years ago

I fixed it. The backend needed to run yarn upgrade @gaia-project/engine in gaia-site. To be able to replay it in the front, it needed to create a new gaia-viewer version.

I didn't replay it but you should be able to now in the admin page.

rzulian commented 6 years ago

I've tried, but I'm getting the same error :(

rzulian commented 6 years ago

Tried now and it worked fine 👍