search

boardgamers / gaia-engine

Javascript engine for project gaia
MIT License
13 stars 6 forks source link

fix regression for advTechTiles #92

Closed rzulian closed 6 years ago

coyotte508 commented 6 years ago

Can you provide a test that is fixed by this?

This is the exact opposite of the last commit I made: https://github.com/donkeytech/gaia-engine/commit/f847de25a7883e872b312ba9e3e6d2c75b44ea18 (in which I edited a test too)

rzulian commented 6 years ago

Your test should fail, you cannot peek a adv tech tile and enter lev 5, unless you have 2 green Federations. On the other end, when you peek an adv tech tile, you can advance in any allowed research area.

coyotte508 commented 6 years ago

Your second commit is good, it fixes the green federation issue. The first commit is unnecessary. Adv tech tiles still could choose any field, since 'adv-gaia' !== 'gaia', so picking adv-gaia doesn't lock the player into advancing gaia track.

rzulian commented 6 years ago

AH boy, you are right ! I thought was 'gaia' === 'gaia', forcing to go to gaia! Anyways, should I reverse the commit?

coyotte508 commented 6 years ago

You can do git revert 9900859 and push :)