boardpack / pydantic-i18n

pydantic-i18n is an extension to support an i18n for the pydantic error messages.
https://pydantic-i18n.boardpack.org
MIT License
83 stars 12 forks source link

πŸ› fix: key's ending after placeholders is not matched #161

Closed niqzart closed 10 months ago

niqzart commented 10 months ago

Hi! I'd like to use this lib in one of my projects, but the bug I in #160 does not allow me to do so. This PR hopefully fixes it. Let me know if any fixes (version bump?) are needed here

github-actions[bot] commented 10 months ago

πŸ“ Docs preview for commit a79be97fd72a0ef146129c9aa415b9cb0d913d76 at: https://653fca5d0799833818b2fa1c--pydantic-i18n.netlify.app

niqzart commented 10 months ago

Also pipelines failed because of something unrelated to my changes (as I see they've been failing for a while), I could also try to fix those, if you need me to

dukkee commented 10 months ago

Hi @niqzart Thank you for the contribution, I will review it soon πŸ™ No worries, I was planning to fix the CI for @boardpack for a whole in the near time

dukkee commented 10 months ago

Hi, @niqzart Please rebase on master, and CI checks should be fine.

Also, could you please add a test case that was mentioned in the issue?

github-actions[bot] commented 10 months ago

πŸ“ Docs preview for commit b59382547f646bceaac58bc00e07781d06918730 at: https://654a9c156b88b9159191aa79--pydantic-i18n.netlify.app

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ea07f99) 100.00% compared to head (487fbd9) 100.00%. Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #161 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 10 Lines 307 317 +10 ========================================= + Hits 307 317 +10 ``` | [Files](https://app.codecov.io/gh/boardpack/pydantic-i18n/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boardpack) | Coverage Ξ” | | |---|---|---| | [pydantic\_i18n/main.py](https://app.codecov.io/gh/boardpack/pydantic-i18n/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boardpack#diff-cHlkYW50aWNfaTE4bi9tYWluLnB5) | `100.00% <100.00%> (ΓΈ)` | | | [tests/test\_main.py](https://app.codecov.io/gh/boardpack/pydantic-i18n/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boardpack#diff-dGVzdHMvdGVzdF9tYWluLnB5) | `100.00% <100.00%> (ΓΈ)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 10 months ago

πŸ“ Docs preview for commit 487fbd9a16319a2120a116528a352925223f69ff at: https://654a9e0dace396123e5da4a3--pydantic-i18n.netlify.app

niqzart commented 10 months ago

Hi! Rebase is done. Sure, I've added a simple test for this case, does it look ok?

dukkee commented 10 months ago

Hi! Rebase is done. Sure, I've added a simple test for this case, does it look ok?

Yes, it's fine. Thanks!