search

boardzilla / boardzilla-core

Boardzilla core library
GNU Affero General Public License v3.0
179 stars 3 forks source link

"6" side of die is upside down #19

Closed VynceMontgomery closed 5 months ago

VynceMontgomery commented 6 months ago

I'm not making a pull request because i haven't completely wrapped my head around what all needs doing, but in: game.scss

         &[data-face="6"] {
           transform: rotate3d(1, 0, 0, 180deg) translateZ(3.1em);
         }

because that rotates about the x axis, the die face is "upside down" - which barely matters, but the pips are lit from the wrong angle, and adding box-shadow inset adds to the wrong corner. I think it would be better to rotate about y: (0,1,0, 180deg)

I suspect that changing this would require - or at least imply? - changing some code a hundred lines down describing the animations, but i haven't tracked down how those are used and ergo what they should be.

VynceMontgomery commented 6 months ago

Actually, I tried this locally to no apparent ill effect; fixed the visual on the 6, the roll spin animations still appear to work the same, etc.

VynceMontgomery commented 5 months ago

per merge on feb 15