Fix reg and de-reg system ID parsing

boatbod / op25

Fork of osmocom OP25 by boatbod

311 stars 97 forks source link

Fix reg and de-reg system ID parsing #183

Closed ilyacodes closed 1 year ago

ilyacodes commented 1 year ago

Current system ID parsing in u_reg_rsp and u_de_reg_ack incorrectly parses system ID as a 16-bit value when it should be a 12-bit value. This results in the RV being prepended to the system ID in cases where the RV is non-zero (various failures).

boatbod commented 1 year ago

Thanks for bringing this to my attention. I have integrated the fix in dev, master and gr310 branches. NOTE: please submit future general pull requests on "dev" branch