search

boazreicher / mosaic-plot

Apache License 2.0
11 stars 2 forks source link

Ignore null values #6

Closed andybaumgar closed 1 year ago

andybaumgar commented 1 year ago

Calculates null count (including overlapping buckets) and uses it to ignore nulls in the average when zeroType == 'empty'.

andybaumgar commented 1 year ago

Hi @boazreicher. I've implemented the ignore null feature from https://github.com/boazreicher/mosaic-plot/issues/5. Let me know if you have any changes etc. Thanks!

boazreicher commented 1 year ago

Hi @andybaumgar , thanks for contributing these changes! Really great that you added an example dashboard as well. I've left some comments on the PR

boazreicher commented 1 year ago

Hi @andybaumgar, the CI job is failing due to linter errors: https://github.com/boazreicher/mosaic-plot/actions/runs/5495510022/jobs/10020237485?pr=6

andybaumgar commented 1 year ago

@boazreicher Sorry about that. I believe I've addressed everything, but the linting errors are not showing up locally for me.