Open casperisfine opened 4 months ago
@boazsegev 👋
Hey @casperisfine I was just trying out this implementation locally and it appears page_methods will need to be updated:
/Users/ben/Repos/combine_pdf/lib/combine_pdf/page_methods.rb:290:in `textbox': can't modify frozen String: "" (FrozenError)
On my local, that's referring to:
contents << box_stream
https://github.com/boazsegev/combine_pdf/blob/master/lib/combine_pdf/page_methods.rb#L288
@BenMorganMY thanks updated. I only relied on the test suite so it appears this wasn't covered.
Fix: https://github.com/boazsegev/combine_pdf/pull/168 Ref: https://bugs.ruby-lang.org/issues/20205
Ruby 3.4 will emit deprecation warnings when mutating string literals, and a future version is likely to make frozen string literals the default.
cc @boazsegev