Fix error empty page in PDF

boazsegev / combine_pdf

A Pure ruby library to merge PDF files, number pages and maybe more...

MIT License

735 stars 157 forks source link

Closed holtmaat closed 7 years ago

holtmaat commented 7 years ago

Empty pages in a PDF document has no object[:Contents] Error: undefined method `delete' for nil:NilClass

Check if object[:Contents] exists

boazsegev commented 7 years ago

Hi @holtmaat , Thanks for the PR!

I'm sorry I'm a bit slow on response times these days - it a busy time in the year for me.

I wrote a short review for the commit. Please have a look before I merge the branch.

Again, Thanks!

holtmaat commented 7 years ago

Hi @boazsegev, Thanks. Where can I find te review?

boazsegev commented 7 years ago

@holtmaat , you should be able to find the review on the GitHub website, in the PR conversation thread, should be at the beginning.

If you're reading this on the website, it should show up a few messages above this one... if it doesn't, please let me know.

holtmaat commented 7 years ago

@boazsegev , there's no review visible on the page https://github.com/boazsegev/combine_pdf/pull/94

boazsegev commented 7 years ago

Cool! Thanks 👍

P.S.

In the change-log, should I simply write "@holtmaat"?

holtmaat commented 7 years ago

👍