search

bob-collective / bob

BOB is a hybrid L2 that combines the security of Bitcoin with the versatility of Ethereum.
https://app.gobob.xyz/
74 stars 37 forks source link

Updating docs for Hello World example #233

Closed ferencdg closed 4 months ago

ferencdg commented 4 months ago

The code for HelloBitcoin.sol has been updated.

I am planning to retag the master branch with tag 1.2.1 after the merge is done. I will reference 1.2.1 version from bob-starter-kit.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 3cc6f2b5e9bfbedc39d9af46801ec51f36481438

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bob ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 8:22am
ferencdg commented 4 months ago

The contract code LGTM. But can you re-deploy the contract on BOB Testnet and update the remix_*.png images in getting-started directory as they are still referencing the old contract deployment?

Also would be helpful if u could open a new issue in bob-starter-kit mentioning the contract in the kit should be updated.

Feel free to skip the above task in this PR if you are planning to open new PRs for it

Hi, I am planning to update the contract in the kit today. Regarding the png, I would rather update it in a follow up PR, as Dom would like me to finish the bob-starter-kit today.

ferencdg commented 4 months ago

closed in favor of PR #234