bob-collective / ui

BOB is a hybrid L2 that combines the security of Bitcoin with the versatility of Ethereum
0 stars 0 forks source link

chore: draft e2e #283

Open slavastartsev opened 2 weeks ago

slavastartsev commented 2 weeks ago

📝 Description

CI configuration https://playwright.dev/docs/ci#on-deployment

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: 4b8260caf7dc41351f4dc31b1deeea98fab936e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bob-mainnet ❌ Failed (Inspect) Nov 13, 2024 9:46am
bob-pay ❌ Failed (Inspect) Nov 13, 2024 9:46am
bob-sepolia ❌ Failed (Inspect) Nov 13, 2024 9:46am
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 9:46am
gitguardian[bot] commented 2 weeks ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [14369921](https://dashboard.gitguardian.com/workspace/277218/incidents/14369921?occurrence=169659471) | Triggered | Generic Password | efdb4dbe0f56bed65f9433faeef471ca6ba7eb61 | .github/workflows/playwright.yml | [View secret](https://github.com/bob-collective/ui/commit/efdb4dbe0f56bed65f9433faeef471ca6ba7eb61#diff-7afcd2d8f7b49bda74843f209eefb7b2da45f7e7803bf2e4bd636699b76aa2d3R35) | | [14369921](https://dashboard.gitguardian.com/workspace/277218/incidents/14369921?occurrence=169653338) | Triggered | Generic Password | d75bf7c092ffa5e10fd2f0aa9a70bd62e1eccc91 | apps/e2e/test/wallet-setup/basic.setup.ts | [View secret](https://github.com/bob-collective/ui/commit/d75bf7c092ffa5e10fd2f0aa9a70bd62e1eccc91#diff-1947946dccabef31b06088cb76eda34df79c0cc2ad89521898aa5b66c7698309R26) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/specifics/private_key_openssh#revoke-the-secret). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.