bob-reus / david-park-barnitz_the-book-of-jade

Other
0 stars 0 forks source link

Review #1

Open dajare opened 6 months ago

dajare commented 6 months ago

Tweaks needed/suggested:

A couple comments:

bob-reus commented 6 months ago

I opted for all-small-caps because it seemed more in line with the styling of headers, similar phrases in dedications, and the like. Leave this for Alex to decide?

Yes, I can see the confusion caused by the opening paragraph: "their" is a non-gendered reference to "author", and "It [presents]" refers back to "The Book of Jade" in the first sentence. I tweaked it a bit.

As for mismatched-dashes and -diacritics, I think so? Since this is poetry and I figured we don't do editorial edits for those (like modernize-spelling), I left the mismatched diacritics and dashes untouched where they didn´t appear to be transcription or printers errors. I've actually reverted some of the changes the PG transcription made to diacritics (closëd, persiä, indiä). Was that a wrong assumption?

I'll add some comments to the css for this and future projects.

dajare commented 6 months ago

That looks good to me, @bob-reus - my dashes/diacritics comment was more for "paper-trail". My sense tallies with yours, and we do want to match the scans, especially with this poetry.

I'll send this up the line to Alex, then!