Review

[vr8hub]

• [x] I don't think most of the things that have been tagged with language spans need them, as they would be pronounced normally with them. E.g., Rue François Premier is going to be pronounced correctly even without the tag. And so on.
• [x] Just a reminder, we don't normally mess with compound words that aren't corrected by modernize spelling. They're not wrong, per se (so nothing needs to be done this time), but they're one-offs because they're not made corpus-wide, and they are work not only for the producer but also for the reviewer, who has to look up each one to make sure it is correct.
• [ ] What does need to be reverted is "none the less"—that and worth while and a couple of others Alex has specifically said to leave alone.
• [x] I appreciate the attention to detail to separate the adding of the phoneme u in ch. 1 from the removal of the quotes, but in this case it isn't necessary. When we change something from quote to italics (books, plays, phonemes, etc.), it's considered formatting and can be done in one step. (You don't need to do anything here, just a note for the future.)
• [x] You have two commits both labeled "Complete content.opf" which obviously can't both be true :), so one should have a different message. I personally would change the latter one to "Add descriptions," but I'll leave it with you to decide.
• [x] I don't think "le beau d'Arcy" needs a tag; d'Arcy is a character name and so doesn't need one, beau is English, and the le is both minor and well known, so the addition of it doesn't change anything. This is similar to the reasoning behind Monsieur le Comte, etc.
• [x] The Wiki URL for the novel is to the disambiguation page; there is no page for the novel, so the entry in the metadata can be removed.
• [x] The poem fragment is actually verse, and should be tagged accordingly; see SEMoS 7.5.6.1.

[vr8hub]

Urggh, I hit submit by accident. I'm not finished with the review, so I may or may not have more to add. IOW, the above may not be all there is. Sorry about that!

[vr8hub]

OK, now I'm done. :)

[bob-reus]

Thank you for your thorough review!

I don't think most of the things that have been tagged with language spans need them, as they would be pronounced normally with them. E.g., Rue François Premier is going to be pronounced correctly even without the tag. And so on.

True, they're not strictly necessary (except for Place), and I chose to err on the side of caution. I've reverted the change for Rue and Avenue.

Just a reminder, we don't normally mess with compound words that aren't corrected by modernize spelling. They're not wrong, per se (so nothing needs to be done this time), but they're one-offs because they're not made corpus-wide, and they are work not only for the producer but also for the reviewer, who has to look up each one to make sure it is correct.

Before, I was told to leave compound words where the change is hyphen to space (or vice versa) as they are, but that the other ones were fine. I'll keep it in mind for the future.

What does need to be reverted is "none the less"—that and worth while and a couple of others Alex has specifically said to leave alone.

I'm aware, but in this case half the instances were spelled 'nonetheless' and the other half 'none the less'. I asked about this in the email thread, and David suggested I normalize to 'none the less'.

I appreciate the attention to detail to separate the adding of the phoneme u in ch. 1 from the removal of the quotes, but in this case it isn't necessary. When we change something from quote to italics (books, plays, phonemes, etc.), it's considered formatting and can be done in one step. (You don't need to do anything here, just a note for the future.)

I believe some reviewers consider adding or removing quotes an editorial commit, so, I don't know what to do here. If the reviewer on my next production tells me it should be editorial, it's going to be a pain to separate them from other, non-editorial formatting in the same commit.

You have two commits both labeled "Complete content.opf" which obviously can't both be true :), so one should have a different message. I personally would change the latter one to "Add descriptions," but I'll leave it with you to decide.

The second commit was supposed to be amended to the first one, but I missed a checkbox :) I have squashed them into a single commit.

I don't think "le beau d'Arcy" needs a tag; d'Arcy is a character name and so doesn't need one, beau is English, and the le is both minor and well known, so the addition of it doesn't change anything. This is similar to the reasoning behind Monsieur le Comte, etc.

Fair, I wasn´t sure about this one. This is fixed.

The Wiki URL for the novel is to the disambiguation page; there is no page for the novel, so the entry in the metadata can be removed.

Yup, I overlooked this. Sloppy. Fixed!

The poem fragment is actually verse, and should be tagged accordingly; see SEMoS 7.5.6.1.

Judging by the context and specifically the line that follows the blockquote ("Beyond, sustained by the arpeggios of the organ, the voice of a singer mounted sheerly like a thread of gold."), and some quick googling, this appears to be a hymn. I've tagged it with z3998:hymn.

[vr8hub]

Before, I was told to leave compound words where the change is hyphen to space (or vice versa) as they are, but that the other ones were fine. I'll keep it in mind for the future.

There's no difference in changing a compound word with a dash or a space; they're all compound words that aren't handled by modernize spelling. Again, they're not wrong, they're just not necessary, they create extra work for you and the reviewer, and they don't really buy us much, because the rest of the corpus almost certainly has instances of all of them. We're never going to tell you to reverse them (unless they're wrong, or on the list Alex has said to leave alone), they're just extra work that's not necessarily worth the effort since they're one-off corrections.

I'm aware, but in this case half the instances were spelled 'nonetheless' and the other half 'none the less'. I asked about this in the email thread, and David suggested I normalize to 'none the less'.

Nope, my bad, I completely read that commit backwards. I swear I'm not dyslexic…

I've tagged it with z3998:hymn. Good catch. I didn't look that closely, I just saw from the ending em-dash that it wasn't a complete quotation, so knew it wasn't poem.

Re the other rest, please, I wish I was this "sloppy." :) In spite of having a ratio of probably 6 to 1 of reviews to personal productions, I still manage to make too many errors in my own stuff.

[vr8hub]

Oops, sorry, just noticed that you didn't change the CSS to reflect hymn rather than poem. (Another thing I too often forget; always rerun lint after making changes, no matter how small the change.)

[bob-reus]

Ah, right! I just amended it to the hymn commit.