search

bob1de / hass-apps

Some useful apps and snippets to empower Home Assistant and AppDaemon even more.
Apache License 2.0
85 stars 23 forks source link

[schedy] Fix AppDaemon 4.0.0 bug re: incorrect callback signature #37

Closed bachya closed 4 years ago

bachya commented 4 years ago

Fixes https://github.com/efficiosoft/hass-apps/issues/36.

AppDaemon 4.0.0 appears to be stricter about callback signatures; this PR fixes one spot (re-evaluation of schedules) where I found this to occur.

bob1de commented 4 years ago

Hi,

Thanks for the PR. I already discussed this "feature" with the AppDaemon devs some months ago and was still hoping they'd drop it again in the final release, but I seem to be in bad luck.

bob1de commented 4 years ago

BTW, this won't even work, because there is no self on a function which is no bound method. I'll end up adding a lot of wrappers around callback handlers for nothing.

bob1de commented 4 years ago

Just for reference: https://github.com/home-assistant/appdaemon/issues/462

bachya commented 4 years ago

Thanks for the clarification!