search

bob7l / HawkReloaded

19 stars 28 forks source link

Item Frames & Armor Stands not properly logged #44

Closed Puremin0rez closed 8 years ago

Puremin0rez commented 9 years ago

Item frames will log the placement and breaking of the frame itself, but not the item added or removed from the frame.

Armor stands are not logged at all. Not even sure there are proper inventory events for armor stands yet?

bob7l commented 9 years ago
  1. This appears to be a 1.8 bug
  2. Armor stands are still very weird. They are considered a LIVING entity by both spigot and minecraft and don't have a lot of API.

Due to the insane amount of bugs in 1.8, i may have to wait for Sponge to come out. I've already began porting the plugin to sponge in a private branch.

RoboMWM commented 8 years ago

Considering you seem to be returning to activity on this, will this be fixed? Currently trying to find a block logger that's open source and compatible with 1.8 items - the only one is CoreProtect, but it's closed source and the author is moving to Sponge.

bob7l commented 8 years ago

Yeah i'll fix it

bob7l commented 8 years ago

I'll commit the fix (Plus more) when i'm done working on my itemserializer. So instead of just the ID of the item, hawkeye will log every "api visible" aspect of the item. I say api visible because we'll still ignore things like custom attributes (Although i believe 1.9 added attribute api! Thanks spigot!)

RoboMWM commented 8 years ago

Cool, I'm fine with remaining within the bounds of the bukkit/spigot/paper API. Thank you for resurrecting this project! Was about to lose hope on finding a properly maintained block logger for Spigot.

bob7l commented 8 years ago

I've fixed the itemframes and made the logging much better. They'll also utilize the new item serializer

I'm not sure whether or not it'll work with previous builds, but i don't see why not.

Post here if you have an issue with it.

On a side note, i'll add armorstand logging soon considering they now have API and 1.8 is much more stable.

Puremin0rez commented 8 years ago

Glad to hear :)

Puremin0rez commented 8 years ago

@bob7l This might not be the best place to submit this issue, but player heads also do not rollback properly if you'd like to look into that.

bob7l commented 8 years ago

@Puremin0rez Yeah i'm aware of that. The only issue is then i'll have to implement block-meta for block related entries rather then just using primitive variables {block-id : block-data}. So i'd have to recode a pretty big portion of the plugin considering it's all hardcoded for just two primitive block values. But that'd also allow for extremely simple expansion / updating at a cost of some performance loss. We'll defiantly have to see because it seems minecraft is adding more and more tile entities with important data attached to them. The meta would probably follow the same layout as the new inventory serializer.

bob7l commented 8 years ago

@RoboMWM

Cool, I'm fine with remaining within the bounds of the bukkit/spigot/paper API.

I'll most likely turn HawkEye modular soon to allow for support for sponge,bukkit, and so on. I was planning on adding sponge support sooner, but sponges API has been extremely dynamic and hard to keep up with.

bob7l commented 8 years ago

I'm going to add rebuild support soon for this enhancement soon aswell.