bobafetthotmail / refind-theme-regular

http://munlik.deviantart.com/art/rEFInd-theme-512091944
Other
783 stars 76 forks source link

Macos centered style #2

Closed Lokdei closed 6 years ago

Lokdei commented 6 years ago
bobafetthotmail commented 6 years ago

Hi, this seems to be a mac-oriented modification. I'm not going to merge this PR as-is in refind-theme-regular as then it would not be good for UEFI/Linux users like me. I like it though, I can add a link to your fork for Mac users in my readme if you want.

If you want to merge your modification in this repo you need to make a folder with different configs so the user can choose the (current) generic/Linux one or your Super-refind config when he installs the theme. And adjust the readme accordingly. It's ok to show screenshots of both the generic and the Super-refind setup if you merge like this.

Lokdei commented 6 years ago

Hey, my bad, I didn't intend to do a pull request to your project just yet. I was still tweaking around the fork and tried to push "new-style" branch into my "master".

I like the idea of having a separate folder for macos. I'll try to continue my changes and once I'm satisfied I'll do a pull request to merge them in.