search

bobafetthotmail / refind-theme-regular

http://munlik.deviantart.com/art/rEFInd-theme-512091944
Other
783 stars 76 forks source link

`include` path in `install.sh` not updated for new themes folder #28

Closed Nathanjms closed 2 years ago

Nathanjms commented 2 years ago

I've tried installing this theme, and it seems to not be able to find it after running the install.sh.

After looking at the install.sh file, it looks like the line 

include refind-theme-regular/theme.conf" | tee -a "${refind_dir}"/refind.conf &> /dev/null

on line 160 needs updating now the theme is going inside the themes folder.

Changing it to 

include themes/refind-theme-regular/theme.conf" | tee -a "${refind_dir}"/refind.conf &> /dev/null

seemed to fix it on my end, so looks like that's all it needs possibly.

I also had to manually add themes/ to the beginning of everything in /boot/efi/EFI/refind/themes/refind-theme-regular/theme.conf.

This was because the file found at src/theme.conf, which is used in install.sh, did not account for the new themes directory. I've updated this, as well as the corresponding lines in install.sh in the PR below.

Nathanjms commented 2 years ago

I've PR'd a fix for this here: bobafetthotmail/refind-theme-regular#29 - let me know if it looks okay!

bobafetthotmail commented 2 years ago

thanks for taking the time to fix this, I probably should have not accepted the split to a themes folder in the first place to avoid messing with a system that was working fine, but oh well.