bobafetthotmail / refind-theme-regular

http://munlik.deviantart.com/art/rEFInd-theme-512091944
Other
783 stars 76 forks source link

Created a new Installation Script for a better user experience and ease of use. #3

Closed KartSriv closed 5 years ago

KartSriv commented 5 years ago

Hey, @bobafetthotmail! I just discovered rEFInd yesterday because my eyes were decaying looking at the GRUB screen. I wanted to install the theme but rather took a little long. So, as an Open Source Contributor, I wrote a simple Shell Script which automates almost all the steps to install. Have a look at the PR and decide if it worth it.

Thanks, @KartSriv

bobafetthotmail commented 5 years ago

That's nice, thanks.

There is a problem on line 41 here https://github.com/bobafetthotmail/refind-theme-regular/pull/3/commits/50b36332d5d3c7759dfbd8cdb89822d36c01ab5a#diff-bea6bcbf10be7598c264cc2426a896eaR41

echo "include refind-theme-regular/theme.conf" > /boot/efi/EFI/refind/refind.conf

This will overwrite the refind conf with the line from echo. It's probably a typo and you wanted to write

echo "include refind-theme-regular/theme.conf" >> /boot/efi/EFI/refind/refind.conf

which will append that line at the end of it.

Also, since you need to change things anyway, could you replace the [Easy] and [Hard] tags in the readme with [Quick] and [Manual]?

Fix that (or make a new PR) and I will merge it.

KartSriv commented 5 years ago

Fixes

here is a problem on line 41 here 50b3633#diff-bea6bcbf10be7598c264cc2426a896eaR41

HOLY S**T!! I didn't notice that, I am sorry : (
Fixed it in 2603282e17f802038851df46bad067d9ea3879b0
Screenshot from 2019-03-28 21-08-56

Also, since you need to change things anyway, could you replace the [Easy] and [Hard] tags in the readme with [Quick] and [Manual]?

There you go - 7c3bece3eaafd4670c025710a26c468aa9ba1a5b

bobafetthotmail commented 5 years ago

Ok thanks, merged.