search

bobafetthotmail / refind-theme-regular

http://munlik.deviantart.com/art/rEFInd-theme-512091944
Other
794 stars 78 forks source link

Add os_astos icons #37

Closed randalthor17 closed 2 years ago

randalthor17 commented 2 years ago

Add icons for astOS, an immutable Arch based distribution utilizing btrfs snapshots. Have been using this for a while, thought I'd open a PR.

randalthor17 commented 2 years ago

Might need a small color change, although I'm not sure which color would match both themes.

bobafetthotmail commented 2 years ago

Yeah I can't merge this as it's not visible with dark/black backgrounds.

You can just add a white background to the icon (similar to Android Apps) so that no matter what is the theme the icon is readable.

The same logic can apply for the bedrock Linux icon too (since the "original" logo is also pure white on black background)

randalthor17 commented 2 years ago

Thanks for the feedback, gonna update soon.

randalthor17 commented 2 years ago

Should I just give it a background or do something like this, where the logo with the background is inside an about 96x96 px rectangle? os_astos

bobafetthotmail commented 2 years ago

That example looks good, yeah a rectangle with rounded corners or a circle is better than a background.

randalthor17 commented 2 years ago

Also, this is what I came up with the Bedrock logo. Is it okay-ish? bedrock_blackbg

randalthor17 commented 2 years ago

Also, the logo for astOS has changed, and this is what I got. os_astos

bobafetthotmail commented 2 years ago

Yeah they look good and readable with the black or white rectangle, if you commit them I will merge this PR.

Lol at astOS changing their logo, but new logo has same readability issues with dark/black backgrounds and needs same workaround (the white rectangle you added).

randalthor17 commented 2 years ago

Done, thanks for the feedback, learned a lot from this PR.

bobafetthotmail commented 2 years ago

Thanks, merged